[Deadcode]: add handling for void magic methods#7781
Closed
parijke wants to merge 1 commit intorectorphp:mainfrom
Closed
[Deadcode]: add handling for void magic methods#7781parijke wants to merge 1 commit intorectorphp:mainfrom
parijke wants to merge 1 commit intorectorphp:mainfrom
Conversation
parijke
changed the title
parijke
force-pushed
the
feature/remove-void-from-magic-methods-as-return-docblock
branch
from
e640c87 to
bb4dc9c
Compare
Contributor
Author
|
This is instead of #7678 |
samsonasik
reviewed
Dec 29, 2025
rules/DeadCode/Rector/ClassMethod/RemoveUselessVoidReturnFromDocblockVoidMagicMethodsRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Dec 29, 2025
rules/DeadCode/Rector/ClassMethod/RemoveUselessVoidReturnFromDocblockVoidMagicMethodsRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 29, 2025
rules/DeadCode/Rector/ClassMethod/RemoveUselessVoidReturnFromDocblockVoidMagicMethodsRector.php
Show resolved
Hide resolved
parijke
force-pushed
the
feature/remove-void-from-magic-methods-as-return-docblock
branch
from
bb4dc9c to
eb1e3f8
Compare
samsonasik
requested changes
Jan 3, 2026
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
Could you register to dead code level set below last "docblock" comment?
rector-src/src/Config/Level/DeadCodeLevel.php
Line 110 in e91db1f
Thank you.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rector rule removes the @return void docblock on magic methods that are void by default